Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(git): commitDate explicitly set default for refDate #1750

Merged
merged 3 commits into from Jan 22, 2023

Conversation

xDivisionByZerox
Copy link
Member

The default value of the refDate option in faker.git.commitDate() is documented as now (new Date()).
This only happens due to the underlying implementation in faker.date.recent().
If the default value in recent() should change in the future, this change ensures that commitDate() still works the same.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Jan 17, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team January 17, 2023 23:37
@xDivisionByZerox xDivisionByZerox self-assigned this Jan 17, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner January 17, 2023 23:37
@xDivisionByZerox
Copy link
Member Author

I'm not sure if this should be labeled as chore, since it doesn't really change anything at runtime currently.

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (next@88d8392). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 0cf26c0 differs from pull request most recent head 94805d9. Consider uploading reports for the commit 94805d9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1750   +/-   ##
=======================================
  Coverage        ?   99.64%           
=======================================
  Files           ?     2340           
  Lines           ?   242612           
  Branches        ?     1103           
=======================================
  Hits            ?   241760           
  Misses          ?      831           
  Partials        ?       21           

ST-DDT
ST-DDT previously approved these changes Jan 18, 2023
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Jan 18, 2023
@ST-DDT ST-DDT requested a review from a team January 18, 2023 01:58
import-brain
import-brain previously approved these changes Jan 18, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Jan 21, 2023

There seems to be a merge conflict. Could you please fix it?

@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Jan 21, 2023
@xDivisionByZerox xDivisionByZerox removed the needs rebase There is a merge conflict label Jan 21, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) January 22, 2023 15:11
@ST-DDT ST-DDT merged commit ee94f3e into next Jan 22, 2023
@ST-DDT ST-DDT deleted the refactor/git/commit-date-default-ref-date branch January 22, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants