Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix see also for non faker.x references #1794

Merged
merged 2 commits into from Jan 30, 2023
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 29, 2023

Found in #1790 (comment)

In vue <template> tags aren't rendered. So we have to use div instead.

Thanks to @Shinigami92 for helping to fix this issue.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Jan 29, 2023
@ST-DDT ST-DDT requested review from a team January 29, 2023 22:31
@ST-DDT ST-DDT self-assigned this Jan 29, 2023
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #1794 (c594331) into next (e6213a8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1794   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2340     2340           
  Lines      234260   234260           
  Branches     1116     1116           
=======================================
  Hits       233427   233427           
  Misses        812      812           
  Partials       21       21           

@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Jan 30, 2023

Can you post a screenshot of what changed here for visual comparison? Were "See Also" simply missing in our docs so far?

Documentation on the next branch seems to be working as intended:
image

@Shinigami92
Copy link
Member

Can you post a screenshot of what changed here for visual comparison? Were "See Also" simply missing in our docs so far?

Documentation on the next branch seems to be working as intended: image

In the current docs, there is no example for this yet, but #1790 (comment) would add one
But you see anyway that the current code is invalid/buggy anyways, so I would appreciate that you approve and trust 🙂

Maybe read this for more info: https://vuejs.org/guide/essentials/conditional.html#v-if-on-template

@ST-DDT expected that v-if/v-else is needed in combination with <template>, but then applied v-html which is not compatible with <template> as that is a non rendered block for just code-flow

@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 30, 2023

I merge this fix now to unblock #1790 .

@ST-DDT ST-DDT enabled auto-merge (squash) January 30, 2023 20:58
@ST-DDT ST-DDT merged commit 05d6eb4 into next Jan 30, 2023
@ST-DDT ST-DDT deleted the docs/fix-see-also branch January 30, 2023 21:04
matthewmayer pushed a commit to matthewmayer/faker that referenced this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants