refactor(datatype): standardize arguments

[xDivisionByZerox]

Part of #1349.

Standardize all function signatures in the DatatypeModule to support an options object.

[xDivisionByZerox]

Should this allow for a number argument?

faker/src/modules/datatype/index.ts

Line 327 in de7ed2e

hexadecimal(

[xDivisionByZerox]

Please run pnpm run generate:locales, pnpm run generate:api-docs, and pnpm run test -u to generate/update the related files,

I did all of them and no other files where generated 🤔

[Shinigami92]

I manually removed test/scripts/apidoc/temp/ and then run pnpm run test -u
Then the snapshots generated newly 🤷

/ping @ST-DDT

[codecov]

Codecov Report

Merging #1804 (4228d44) into next (667599d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #1804      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files        2346     2346              
  Lines      235500   235519      +19     
  Branches     1140     1138       -2     
==========================================
+ Hits       234635   234651      +16     
- Misses        843      846       +3     
  Partials       22       22              

Impacted Files	Coverage Δ
src/modules/datatype/index.ts	100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts	89.94% <0.00%> (-1.48%)	⬇️
src/modules/location/index.ts	98.91% <0.00%> (+0.21%)	⬆️

[ST-DDT]

I did all of them and no other files where generated 🤔

Worked for me without issues.

[xDivisionByZerox]

I did all of them and no other files where generated 🤔

Worked for me without issues.

I work on a windows machine. Might that be a problem somehow? Just the only thing that comes to mind right now...

[ST-DDT]

I work on a windows machine.

I as well. Did you run pnpm run build before running pnpm run test -u?

[xDivisionByZerox]

I as well. Did you run pnpm run build before running pnpm run test -u?

No, I didn't 🤔
Why would that be required to update the snapshots? Vitest is run against the typescript source, no?

But thanks for the info, I'll do that next time.

[matthewmayer]

seems weird to change the signature when the method is already deprecated in this version. If you are currently using

faker.datatype.string(42) we want you to change to faker.string.sample({length:42}) rather than faker.datatype.string({length:42}) no?

[xDivisionByZerox]

seems weird to change the signature when the method is already deprecated in this version. If you are currently using

faker.datatype.string(42) we want you to change to faker.string.sample({length:42}) rather than faker.datatype.string({length:42}) no?

Due to #1349, faker.string.* will be standardized as well in a later PR as well. I'm currently scoping related PR per module (for reviewing reasons).