Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: activate noImplicitAny #1839

Merged
merged 12 commits into from
Feb 15, 2023
Merged

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Feb 14, 2023

closes #1837

This PR does only build time and no runtime changes on purpose
Otherwise I would suggest to modify some codeflow in later PRs (if really needed)

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Feb 14, 2023
@Shinigami92 Shinigami92 self-assigned this Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #1839 (edb815a) into next (1399375) will decrease coverage by 0.02%.
The diff coverage is 92.72%.

❗ Current head edb815a differs from pull request most recent head 648d0a7. Consider uploading reports for the commit 648d0a7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1839      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.02%     
==========================================
  Files        2346     2346              
  Lines      236394   235810     -584     
  Branches     1144     1136       -8     
==========================================
- Hits       235527   234918     -609     
- Misses        845      870      +25     
  Partials       22       22              
Impacted Files Coverage Δ
src/utils/types.ts 0.00% <0.00%> (ø)
src/modules/airline/index.ts 100.00% <100.00%> (ø)
src/modules/animal/index.ts 100.00% <100.00%> (ø)
src/modules/color/index.ts 99.79% <100.00%> (+<0.01%) ⬆️
src/modules/commerce/index.ts 100.00% <100.00%> (ø)
src/modules/company/index.ts 100.00% <100.00%> (ø)
src/modules/database/index.ts 100.00% <100.00%> (ø)
src/modules/datatype/index.ts 100.00% <100.00%> (ø)
src/modules/date/index.ts 99.79% <100.00%> (-0.21%) ⬇️
src/modules/finance/index.ts 100.00% <100.00%> (ø)
... and 23 more

@Shinigami92 Shinigami92 marked this pull request as ready for review February 14, 2023 09:00
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 14, 2023 09:00
@Shinigami92
Copy link
Member Author

Shinigami92 commented Feb 14, 2023

@xDivisionByZerox Oh I see, the Callable was just a replacement for Function which should not be used in TS as a type as it is a real thing (e.g. like String)

The suggested way is just to use () => void instead and therefore I removed the type alias and inlined it as this is the way it should be done and is suggested by TS

This also removed the bad worded comment For some strange reason ... which sounds a bit unprofessional

@Shinigami92
Copy link
Member Author

The "test"-code failed 👀
I need to check that later, I will leave my home soon and come back in some hours

src/modules/helpers/index.ts Outdated Show resolved Hide resolved
src/modules/helpers/unique.ts Outdated Show resolved Hide resolved
src/utils/types.ts Outdated Show resolved Hide resolved
src/utils/types.ts Outdated Show resolved Hide resolved
@ST-DDT
Copy link
Member

ST-DDT commented Feb 14, 2023

The suggested way is just to use () => void instead and therefore I removed the type alias and inlined it as this is the way it should be done and is suggested by TS

This also removed the bad worded comment For some strange reason ... which sounds a bit unprofessional

Soon:

ST-DDT
ST-DDT previously approved these changes Feb 14, 2023
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: infra Changes to our infrastructure or project setup labels Feb 14, 2023
@ST-DDT ST-DDT requested review from a team February 14, 2023 21:16
Co-authored-by: DivisionByZero <leyla.jaehnig@gmx.de>
src/utils/types.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team February 14, 2023 21:50
@ST-DDT ST-DDT enabled auto-merge (squash) February 15, 2023 18:23
@ST-DDT ST-DDT merged commit e7230f6 into next Feb 15, 2023
@ST-DDT ST-DDT deleted the 1837-turn-on-noimplicitany-in-tsconfig branch February 15, 2023 18:31
matthewmayer pushed a commit to matthewmayer/faker that referenced this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Turn on noImplicitAny in tsconfig
3 participants