Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(datatype): deprecate json #1852

Merged
merged 4 commits into from Feb 18, 2023
Merged

refactor(datatype): deprecate json #1852

merged 4 commits into from Feb 18, 2023

Conversation

xDivisionByZerox
Copy link
Member

Part of #1851.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: datatype Something is referring to the datatype module deprecation A deprecation was made in the PR labels Feb 16, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team February 16, 2023 21:53
@xDivisionByZerox xDivisionByZerox self-assigned this Feb 16, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner February 16, 2023 21:53
@xDivisionByZerox xDivisionByZerox changed the title refactor(datatype): deprecate json refactor(datatype): deprecate json Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023 •
edited

Codecov Report

Merging #1852 (a962dd3) into next (6b41a79) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1852      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files        2346     2346              
  Lines      236471   236480       +9     
  Branches     1149     1145       -4     
==========================================
- Hits       235615   235612       -3     
- Misses        834      846      +12     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/datatype/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 91.42% <0.00%> (-2.96%) ⬇️
src/modules/location/index.ts 98.70% <0.00%> (-0.22%) ⬇️

ST-DDT
ST-DDT previously approved these changes Feb 16, 2023
View reviewed changes
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Feb 16, 2023
@ST-DDT ST-DDT requested a review from a team February 16, 2023 23:20
import-brain
import-brain reviewed Feb 17, 2023
View reviewed changes
src/modules/datatype/index.ts Outdated Show resolved Hide resolved
src/modules/datatype/index.ts Outdated Show resolved Hide resolved
@Shinigami92 @import-brain
fix typo
6c17764 
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
@xDivisionByZerox xDivisionByZerox linked an issue Feb 17, 2023 that may be closed by this pull request
Deprecate datatype.json() and datatype.array() for removal #1851
Closed
@ST-DDT ST-DDT requested a review from a team February 17, 2023 11:51
@ST-DDT ST-DDT enabled auto-merge (squash) February 18, 2023 14:59
@ST-DDT ST-DDT merged commit fccd641 into next Feb 18, 2023
@ST-DDT ST-DDT deleted the refactor/datatype/deprecate-json branch February 18, 2023 18:38
@balena-renovate balena-renovate bot mentioned this pull request Aug 18, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR m: datatype Something is referring to the datatype module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Deprecate datatype.json() and datatype.array() for removal
4 participants
@xDivisionByZerox @ST-DDT @Shinigami92 @import-brain