-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(number): replace RegExp with validation functions #1857
Merged
ST-DDT
merged 7 commits into
next
from
test/number/decouple-type-check-from-implementation
Mar 23, 2023
Merged
test(number): replace RegExp with validation functions #1857
ST-DDT
merged 7 commits into
next
from
test/number/decouple-type-check-from-implementation
Mar 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDivisionByZerox
added
p: 1-normal
Nothing urgent
c: test
m: number
Something is referring to the number module
labels
Feb 19, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1857 +/- ##
==========================================
- Coverage 99.63% 99.63% -0.01%
==========================================
Files 2384 2384
Lines 238991 238991
Branches 1231 1231
==========================================
- Hits 238125 238122 -3
- Misses 844 847 +3
Partials 22 22 |
Shinigami92
reviewed
Feb 19, 2023
ST-DDT
approved these changes
Mar 20, 2023
import-brain
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the type validation in tests for the
NumberModule
.Reasoning
This statement is from the projects CONTRIBUTING.md. The word of interest here is preferably. This is because RexExp can get out of hand really quickly and does not always result in easy-to-understand error messages since they only provide the RegExp and no information on where the error exactly happened.
This problem persist with Validation functions. But, they result in the error message providing the function's name which allows for a quicker evaluation of the actual problem if it is descriptive enough.