Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add 'Sourcing data for definitions' to CONTRIBUTING #1888

Merged
merged 3 commits into from Mar 9, 2023
Merged

docs: Add 'Sourcing data for definitions' to CONTRIBUTING #1888

merged 3 commits into from Mar 9, 2023

Conversation

matthewmayer
Copy link
Contributor

fix #1820

@matthewmayer matthewmayer requested a review from a team March 3, 2023 04:05
@matthewmayer matthewmayer requested a review from a team as a code owner March 3, 2023 04:05
@codecov
Copy link

codecov bot commented Mar 3, 2023 •
edited

Codecov Report

Merging #1888 (0f459bd) into next (f8926c7) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1888   +/-   ##
=======================================
  Coverage   99.61%   99.62%           
=======================================
  Files        2356     2356           
  Lines      236570   236570           
  Branches     1188     1191    +3     
=======================================
+ Hits       235670   235680   +10     
+ Misses        878      868   -10     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 87.86% <0.00%> (+2.95%) ⬆️

@matthewmayer matthewmayer self-assigned this Mar 3, 2023
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 3, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Mar 3, 2023

I like it. Should we add a section regarding the requirement to be "fit for professional audience"?

@ST-DDT ST-DDT requested review from a team March 4, 2023 23:28
@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Mar 4, 2023
@Shinigami92
Copy link
Member

I like it. Should we add a section regarding the requirement to be "fit for professional audience"?

This is (theoretically) already covered by Code of Conduct
It's also not really related to the source for the data

The only helpful thing would be to co-reference links from and to CoC

@ST-DDT ST-DDT enabled auto-merge (squash) March 9, 2023 17:33
@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Mar 9, 2023
@ST-DDT ST-DDT merged commit 6ba21c6 into faker-js:next Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Add section to CONTRIBUTING about how to source data
5 participants
@matthewmayer @ST-DDT @Shinigami92 @import-brain @xDivisionByZerox