Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix nested parameter defaults #1931

Merged
merged 4 commits into from Mar 16, 2023
Merged

docs: fix nested parameter defaults #1931

merged 4 commits into from Mar 16, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 14, 2023

@ST-DDT ST-DDT added c: bug Something isn't working c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 14, 2023
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Mar 14, 2023
@ST-DDT ST-DDT requested review from a team March 14, 2023 20:57
@ST-DDT ST-DDT self-assigned this Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023 •
edited

Codecov Report

Merging #1931 (24ea65e) into next (65e6b7f) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1931   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2357     2357           
  Lines      236856   236856           
  Branches     1226     1230    +4     
=======================================
+ Hits       235971   235981   +10     
+ Misses        863      853   -10     
  Partials       22       22

see 1 file with indirect coverage changes

@ST-DDT ST-DDT requested review from a team March 15, 2023 12:02
@ST-DDT ST-DDT mentioned this pull request Mar 16, 2023
Merged
@ST-DDT ST-DDT enabled auto-merge (squash) March 16, 2023 22:55
@ST-DDT ST-DDT merged commit 8cc47e6 into next Mar 16, 2023
@ST-DDT ST-DDT deleted the docs/fix-nested-parameter-defaults branch March 16, 2023 23:03
@ST-DDT ST-DDT linked an issue Mar 20, 2023 that may be closed by this pull request
Default parameter value not showing up in faker.date.recent documentation #1927
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: bug Something isn't working c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

Default parameter value not showing up in faker.date.recent documentation
3 participants
@ST-DDT @matthewmayer @Shinigami92