Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use enumValue #1937

Merged
merged 3 commits into from
Mar 16, 2023
Merged

chore: use enumValue #1937

merged 3 commits into from
Mar 16, 2023

Conversation

Shinigami92
Copy link
Member

Uses the new enumValue function from

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Mar 15, 2023
@Shinigami92 Shinigami92 self-assigned this Mar 15, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 15, 2023 16:48
@Shinigami92 Shinigami92 requested a review from a team March 15, 2023 16:48
@codecov
Copy link

codecov bot commented Mar 15, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (next@8cc47e6). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head ab895f2 differs from pull request most recent head a6dca64. Consider uploading reports for the commit a6dca64 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1937   +/-   ##
=======================================
  Coverage        ?   99.63%           
=======================================
  Files           ?     2357           
  Lines           ?   236856           
  Branches        ?     1230           
=======================================
  Hits            ?   235995           
  Misses          ?      839           
  Partials        ?       22
Impacted Files Coverage Δ
src/modules/airline/index.ts 100.00% <100.00%> (ø)
src/modules/color/index.ts 99.79% <100.00%> (ø)
src/modules/person/index.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 15, 2023
@ST-DDT ST-DDT requested review from a team March 15, 2023 22:18
@ST-DDT ST-DDT enabled auto-merge (squash) March 16, 2023 22:55
@ST-DDT ST-DDT merged commit ee3c3b0 into next Mar 16, 2023
@ST-DDT ST-DDT deleted the use-enum-value-function branch March 16, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shinigami92 @ST-DDT @xDivisionByZerox