Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(locale): added dedicated swiss street names #1946

Merged

Conversation

asharnadeem
Copy link
Contributor

fix for #1907

adds a file for de_CH, street_name, that uses a dedicated list of street names that are common to Switzerland. all streets are pulled from state directories and actually exist

@asharnadeem asharnadeem requested a review from a team as a code owner March 18, 2023 01:40
@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #1946 (dbc5ceb) into next (f6c8ca3) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1946      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2357     2358       +1     
  Lines      236875   236907      +32     
  Branches     1230     1226       -4     
==========================================
+ Hits       236004   236026      +22     
- Misses        849      859      +10     
  Partials       22       22              
Impacted Files Coverage Δ
src/locales/de_CH/location/index.ts 100.00% <100.00%> (ø)
src/locales/de_CH/location/street.ts 100.00% <100.00%> (ø)
src/locales/de_CH/location/street_name.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Mar 18, 2023
@ST-DDT ST-DDT requested review from a team March 18, 2023 09:19
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FFR: Faker does not care about whether generated values exist. Many of the provided street names share a common suffix like weg, strasse or gasse. This could potentially be extracted in the future so that the street patterns could include "fake" names.

@ST-DDT ST-DDT merged commit 1d4b4b8 into faker-js:next Mar 18, 2023
@asharnadeem asharnadeem deleted the chore/locale_add-swiss-street-names branch May 5, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants