Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(locale): change uk_country to state #1989

Merged
merged 1 commit into from Mar 29, 2023

Conversation

matthewmayer
Copy link
Contributor

part of #1944

Since the decision was to use location.state() for 1st level admin regions and location.county() for 2nd level admin regions

It would be confusing to use state() for counties in en_GB.

Instead, move the currently unused/inaccessible (except via faker.fake) uk_country as the 1st level admin area. This would be more intuitive for
British users.

@matthewmayer matthewmayer requested a review from a team as a code owner March 29, 2023 08:34
@matthewmayer matthewmayer added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Mar 29, 2023
@matthewmayer matthewmayer self-assigned this Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #1989 (5bacc76) into next (f890d62) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1989      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2458     2458              
  Lines      239905   239905              
  Branches     1278     1278              
==========================================
- Hits       238999   238996       -3     
- Misses        883      886       +3     
  Partials       23       23              
Impacted Files Coverage Δ
src/locales/en_GB/location/state.ts 100.00% <ø> (ø)
src/locales/en_GB/location/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested review from a team March 29, 2023 08:41
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 29, 2023
@Shinigami92 Shinigami92 merged commit bbf65d8 into faker-js:next Mar 29, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants