Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add hu states #1990

Merged
merged 3 commits into from Mar 30, 2023
Merged

Conversation

matthewmayer
Copy link
Contributor

part of #1977
add the 19 counties (vármegyék) of Hungary, plus the capital city (főváros) Budapest, which together make up the 1st level administrative areas

ref
https://en.wikipedia.org/wiki/Counties_of_Hungary
https://hu.wikipedia.org/wiki/Magyarorsz%C3%A1g_v%C3%A1rmegy%C3%A9i_(2023%E2%80%93)
https://infostart.hu/belfold/2023/01/02/uj-tablak-leptek-el-a-magyar-orszagutakat-galeria

@matthewmayer matthewmayer requested a review from a team as a code owner March 29, 2023 09:57
@matthewmayer matthewmayer added c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent labels Mar 29, 2023
@matthewmayer matthewmayer self-assigned this Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (next@6ba5093). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 359bed6 differs from pull request most recent head b821d1e. Consider uploading reports for the commit b821d1e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1990   +/-   ##
=======================================
  Coverage        ?   99.61%           
=======================================
  Files           ?     2462           
  Lines           ?   239978           
  Branches        ?     1270           
=======================================
  Hits            ?   239045           
  Misses          ?      910           
  Partials        ?       23           
Impacted Files Coverage Δ
src/locales/hu/index.ts 100.00% <100.00%> (ø)
src/locales/hu/location/index.ts 100.00% <100.00%> (ø)
src/locales/hu/location/state.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 29, 2023
@ST-DDT ST-DDT requested review from a team March 29, 2023 15:24
@ST-DDT ST-DDT enabled auto-merge (squash) March 30, 2023 15:06
@ST-DDT ST-DDT merged commit 3ae3691 into faker-js:next Mar 30, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants