Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): rename ge to ka_GE #2010

Merged
merged 4 commits into from
Apr 3, 2023

Conversation

matthewmayer
Copy link
Contributor

fix #1975

@matthewmayer matthewmayer requested a review from a team April 2, 2023 13:24
@matthewmayer matthewmayer requested a review from a team as a code owner April 2, 2023 13:24
@matthewmayer matthewmayer self-assigned this Apr 2, 2023
@matthewmayer matthewmayer added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions labels Apr 2, 2023
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #2010 (262c25f) into next (cbbc076) will decrease coverage by 0.01%.
The diff coverage is 64.51%.

❗ Current head 262c25f differs from pull request most recent head d1c52ae. Consider uploading reports for the commit d1c52ae to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2010      +/-   ##
==========================================
- Coverage   99.61%   99.61%   -0.01%     
==========================================
  Files        2561     2562       +1     
  Lines      243229   243251      +22     
  Branches     1273     1277       +4     
==========================================
+ Hits       242298   242313      +15     
- Misses        906      912       +6     
- Partials       25       26       +1     
Impacted Files Coverage Δ
src/locale/ge.ts 0.00% <0.00%> (-100.00%) ⬇️
src/locales/ka_GE/cell_phone/formats.ts 100.00% <ø> (ø)
src/locales/ka_GE/cell_phone/index.ts 100.00% <ø> (ø)
src/locales/ka_GE/company/index.ts 100.00% <ø> (ø)
src/locales/ka_GE/company/name_patterns.ts 100.00% <ø> (ø)
src/locales/ka_GE/company/prefix.ts 100.00% <ø> (ø)
src/locales/ka_GE/company/suffix.ts 100.00% <ø> (ø)
src/locales/ka_GE/internet/domain_suffix.ts 100.00% <ø> (ø)
src/locales/ka_GE/internet/free_email.ts 100.00% <ø> (ø)
src/locales/ka_GE/internet/index.ts 100.00% <ø> (ø)
... and 30 more

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested review from a team April 2, 2023 21:00
@ST-DDT ST-DDT enabled auto-merge (squash) April 3, 2023 15:43
@ST-DDT ST-DDT merged commit 1f763f8 into faker-js:next Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Wrong ISO code used for Georgian locale
3 participants