Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename type to singular #2052

Merged
merged 1 commit into from Apr 15, 2023
Merged

test: rename type to singular #2052

merged 1 commit into from Apr 15, 2023

Conversation

Shinigami92
Copy link
Member

While working on #2046 I found this type definition with is ending on an s
In the same YouTube video it was suggested to not use plural form for such cases

@Shinigami92 Shinigami92 added c: chore PR that doesn't affect the runtime behavior c: test labels Apr 15, 2023
@Shinigami92 Shinigami92 self-assigned this Apr 15, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 15, 2023 16:01
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #2052 (4000767) into next (5e421b0) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2052      +/-   ##
==========================================
- Coverage   99.61%   99.60%   -0.01%     
==========================================
  Files        2535     2535              
  Lines      241583   241583              
  Branches     1283     1281       -2     
==========================================
- Hits       240650   240637      -13     
- Misses        906      919      +13     
  Partials       27       27              

see 1 file with indirect coverage changes

@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Apr 15, 2023
@ST-DDT ST-DDT requested review from a team April 15, 2023 17:19
@ST-DDT ST-DDT merged commit bc58f22 into next Apr 15, 2023
17 checks passed
@ST-DDT ST-DDT deleted the rename-type-1 branch April 15, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: test p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants