Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unify todos #2063

Merged
merged 1 commit into from Apr 16, 2023
Merged

chore: unify todos #2063

merged 1 commit into from Apr 16, 2023

Conversation

Shinigami92
Copy link
Member

this just unifies the TODOs to follow all the same pattern

hint: you can use user snippets in VSCode to add a short suggestion for this like e.g.:

{
  // Place your global snippets here. Each snippet is defined under a snippet name and has a scope, prefix, body and
  // description. Add comma separated ids of the languages where the snippet is applicable in the scope field. If scope
  // is left empty or omitted, the snippet gets applied to all languages. The prefix is what is
  // used to trigger the snippet and the body will be expanded and inserted. Possible variables are:
  // $1, $2 for tab stops, $0 for the final cursor position, and ${1:label}, ${2:another} for placeholders.
  // Placeholders with the same ids are connected.
  // Example:
  // "Print to console": {
  //     "scope": "javascript,typescript",
  //     "prefix": "log",
  //     "body": [
  //         "console.log('$1');",
  //         "$2"
  //     ],
  //     "description": "Log output to console"
  // }
  "todo-c": {
    "prefix": "todo-c",
    "body": "$LINE_COMMENT TODO christopher $CURRENT_YEAR-$CURRENT_MONTH-$CURRENT_DATE: $1"
  },
  "todo-s": {
    "prefix": "todo-s",
    "body": "$LINE_COMMENT TODO @Shinigami92 $CURRENT_YEAR-$CURRENT_MONTH-$CURRENT_DATE: $1"
  }
}

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Apr 16, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 16, 2023 13:50
@Shinigami92 Shinigami92 self-assigned this Apr 16, 2023
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Apr 16, 2023
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency purposes

@ST-DDT ST-DDT requested review from a team April 16, 2023 13:58
@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #2063 (a97af2c) into next (ec4d428) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2063   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files        2535     2535           
  Lines      241583   241583           
  Branches     1278     1284    +6     
=======================================
+ Hits       240641   240654   +13     
+ Misses        915      902   -13     
  Partials       27       27           
Impacted Files Coverage Δ
src/utils/types.ts 0.00% <0.00%> (ø)
src/modules/helpers/index.ts 99.05% <100.00%> (ø)
src/modules/helpers/unique.ts 98.78% <100.00%> (ø)
src/modules/image/providers/lorempicsum.ts 91.71% <100.00%> (ø)

... and 2 files with indirect coverage changes

@xDivisionByZerox xDivisionByZerox added the s: accepted Accepted feature / Confirmed bug label Apr 16, 2023
@ST-DDT ST-DDT merged commit 153e0ca into next Apr 16, 2023
17 checks passed
@ST-DDT ST-DDT deleted the chore-unify-todos branch April 16, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants