Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(location): deprecate streetName #2071

Merged
merged 3 commits into from Apr 21, 2023
Merged

refactor(location): deprecate streetName #2071

merged 3 commits into from Apr 21, 2023

Conversation

Shinigami92
Copy link
Member

references #2020

should be merged before #2051

@Shinigami92 Shinigami92 added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module deprecation A deprecation was made in the PR labels Apr 20, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 20, 2023 17:27
@Shinigami92 Shinigami92 self-assigned this Apr 20, 2023
@Shinigami92 Shinigami92 requested a review from a team April 20, 2023 17:27
@Shinigami92 Shinigami92 requested a review from a team April 20, 2023 17:30
@Shinigami92 Shinigami92 mentioned this pull request Apr 20, 2023
Merged
@codecov
Copy link

codecov bot commented Apr 20, 2023 •
edited

Codecov Report

Merging #2071 (ae1d6a2) into next (bf67a21) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ae1d6a2 differs from pull request most recent head 250506d. Consider uploading reports for the commit 250506d to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2071   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files        2535     2535           
  Lines      242202   242212   +10     
  Branches     1293     1295    +2     
=======================================
+ Hits       241267   241289   +22     
+ Misses        908      896   -12     
  Partials       27       27
Impacted Files Coverage Δ
src/modules/location/index.ts 99.00% <100.00%> (-0.16%) ⬇️

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested review from a team April 20, 2023 17:48
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Apr 20, 2023
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 21, 2023 16:28
@Shinigami92 Shinigami92 merged commit 2a6f578 into next Apr 21, 2023
15 checks passed
@Shinigami92 Shinigami92 deleted the 2020-deprecate-street-name branch April 21, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR m: location Something is referring to the location module s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shinigami92 @ST-DDT @xDivisionByZerox