Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add en_HK locale #2083

Merged
merged 8 commits into from Apr 25, 2023
Merged

Conversation

matthewmayer
Copy link
Contributor

Adds a locale for English (Hong Kong)

A few points of note:

  • Hong Kong has no ZIP codes
  • Override surnames but fall back to en first names
  • Street names are generated with a mix of English and Cantonese parts

@matthewmayer matthewmayer requested a review from a team April 23, 2023 09:55
@matthewmayer matthewmayer requested a review from a team as a code owner April 23, 2023 09:55
@matthewmayer matthewmayer added c: feature Request for new feature p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Apr 23, 2023
@matthewmayer matthewmayer self-assigned this Apr 23, 2023
@matthewmayer matthewmayer changed the title feat(locale) - add en_HK locale feat(locale): add en_HK locale Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #2083 (437ef21) into next (76c3080) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2083      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files        2541     2567      +26     
  Lines      242800   243322     +522     
  Branches     1249     1246       -3     
==========================================
+ Hits       241827   242325     +498     
- Misses        946      970      +24     
  Partials       27       27              
Impacted Files Coverage Δ
src/locale/en_HK.ts 100.00% <100.00%> (ø)
src/locale/index.ts 100.00% <100.00%> (ø)
src/locales/en_HK/company/index.ts 100.00% <100.00%> (ø)
src/locales/en_HK/company/suffix.ts 100.00% <100.00%> (ø)
src/locales/en_HK/index.ts 100.00% <100.00%> (ø)
src/locales/en_HK/internet/domain_suffix.ts 100.00% <100.00%> (ø)
src/locales/en_HK/internet/index.ts 100.00% <100.00%> (ø)
src/locales/en_HK/location/building_number.ts 100.00% <100.00%> (ø)
src/locales/en_HK/location/city.ts 100.00% <100.00%> (ø)
src/locales/en_HK/location/default_country.ts 100.00% <100.00%> (ø)
... and 18 more

... and 1 file with indirect coverage changes

@ST-DDT
Copy link
Member

ST-DDT commented Apr 23, 2023

Note to self: Update migration guide to use post codes: #2004 (comment) once this is merged.

Shinigami92
Shinigami92 previously approved these changes Apr 23, 2023
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already give my approval, but looks like I need to re-approve again later

src/locales/en_HK/location/city.ts Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team April 24, 2023 08:08
@ST-DDT
Copy link
Member

ST-DDT commented Apr 24, 2023

Note to self: Update migration guide to use post codes: #2004 (comment) once this is merged.

@matthewmayer update docs

My original intention was to do that in a separate PR, but this works as well. Thanks for your help! 👍

@ST-DDT ST-DDT requested a review from Shinigami92 April 24, 2023 08:10
@ST-DDT ST-DDT merged commit 698fd7d into faker-js:next Apr 25, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants