Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): add ro_MD locale #2084

Merged
merged 10 commits into from May 1, 2023
Merged

feat(locale): add ro_MD locale #2084

merged 10 commits into from May 1, 2023

Conversation

matthewmayer
Copy link
Contributor

Rebased version of #1936 by @botzill

@matthewmayer matthewmayer requested a review from a team April 23, 2023 10:09
@matthewmayer matthewmayer requested a review from a team as a code owner April 23, 2023 10:09
@matthewmayer matthewmayer self-assigned this Apr 23, 2023
@matthewmayer matthewmayer added c: feature Request for new feature c: locale Permutes locale definitions p: 1-normal Nothing urgent labels Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023 •
edited

Codecov Report

Merging #2084 (c5c56a4) into next (ec1ca12) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c5c56a4 differs from pull request most recent head 8b85d0f. Consider uploading reports for the commit 8b85d0f to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2084      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files        2567     2605      +38     
  Lines      243394   244968    +1574     
  Branches     1254     1252       -2     
==========================================
+ Hits       242420   243981    +1561     
- Misses        947      960      +13     
  Partials       27       27
Impacted Files Coverage Δ
src/locale/index.ts 100.00% <100.00%> (ø)
src/locale/ro_MD.ts 100.00% <100.00%> (ø)
src/locales/index.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/cell_phone/formats.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/cell_phone/index.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/date/index.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/date/month.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/date/weekday.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/index.ts 100.00% <100.00%> (ø)
src/locales/ro_MD/internet/domain_suffix.ts 100.00% <100.00%> (ø)
... and 30 more

... and 2 files with indirect coverage changes

@matthewmayer matthewmayer changed the title feat(locale): add ro_MD feat(locale): add ro_MD locale Apr 23, 2023
Shinigami92
Shinigami92 previously approved these changes Apr 25, 2023
View reviewed changes
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label May 1, 2023
@ST-DDT
Copy link
Member

ST-DDT commented May 1, 2023

This PR needs to be updated by running the generate locales script again.

@matthewmayer matthewmayer removed the needs rebase There is a merge conflict label May 1, 2023
@ST-DDT ST-DDT requested review from a team May 1, 2023 10:18
@ST-DDT ST-DDT requested a review from a team May 1, 2023 21:24
@ST-DDT ST-DDT enabled auto-merge (squash) May 1, 2023 21:28
@ST-DDT ST-DDT merged commit 08cf1d8 into faker-js:next May 1, 2023
15 checks passed
@matthewmayer matthewmayer mentioned this pull request May 13, 2023
Merged
matthewmayer added a commit to matthewmayer/faker that referenced this pull request May 13, 2023
@matthewmayer
fix(locale) ro_MD city should be city_pattern
30c6e3d 
conflict of faker-js#2084 and faker-js#2094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: feature Request for new feature c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewmayer @ST-DDT @Shinigami92 @xDivisionByZerox