Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for equals on locale proxies #2092

Merged
merged 3 commits into from Apr 25, 2023
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 24, 2023

For some strange reason, both toEqual() and not.toEqual() don't work on locale proxies.
This PR fixes that. There might be some internal magic at play.
See the commit with the test for more details about the error.

grafik

@ST-DDT ST-DDT added c: bug Something isn't working p: 2-high Fix main branch labels Apr 24, 2023
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Apr 24, 2023
@ST-DDT ST-DDT requested review from a team April 24, 2023 12:37
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #2092 (0c69cd0) into next (76c3080) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0c69cd0 differs from pull request most recent head 1985111. Consider uploading reports for the commit 1985111 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2092   +/-   ##
=======================================
  Coverage   99.59%   99.60%           
=======================================
  Files        2541     2541           
  Lines      242800   242806    +6     
  Branches     1249     1254    +5     
=======================================
+ Hits       241827   241836    +9     
+ Misses        946      943    -3     
  Partials       27       27           
Impacted Files Coverage Δ
src/locale-proxy.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT changed the title fix: add support for not equals on locale proxies fix: add support for equals on locale proxies Apr 24, 2023
@ST-DDT ST-DDT requested review from a team April 24, 2023 16:06
@ST-DDT ST-DDT enabled auto-merge (squash) April 25, 2023 15:09
@ST-DDT ST-DDT merged commit 4d0458c into next Apr 25, 2023
15 checks passed
@Shinigami92 Shinigami92 deleted the fix/locale-proxy/not-equals branch April 25, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 2-high Fix main branch
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants