Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix full url to absolute conversion #2101

Merged
merged 4 commits into from Apr 28, 2023
Merged

docs: fix full url to absolute conversion #2101

merged 4 commits into from Apr 28, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 27, 2023

@ST-DDT ST-DDT added c: bug Something isn't working c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Apr 27, 2023
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Apr 27, 2023
@ST-DDT ST-DDT self-assigned this Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023 •
edited

Codecov Report

Merging #2101 (6fefa5f) into next (76c3080) will decrease coverage by 0.02%.
The diff coverage is 99.85%.

❗ Current head 6fefa5f differs from pull request most recent head 8c2e45b. Consider uploading reports for the commit 8c2e45b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2101      +/-   ##
==========================================
- Coverage   99.59%   99.58%   -0.02%     
==========================================
  Files        2541     2567      +26     
  Lines      242800   243365     +565     
  Branches     1249     1249              
==========================================
+ Hits       241827   242365     +538     
- Misses        946      973      +27     
  Partials       27       27
Impacted Files Coverage Δ
src/definitions/location.ts 0.00% <0.00%> (ø)
src/internal/deprecated.ts 100.00% <ø> (ø)
src/locales/af_ZA/location/city_pattern.ts 100.00% <ø> (ø)
src/locales/ar/location/city_pattern.ts 100.00% <ø> (ø)
src/locales/az/location/city_pattern.ts 100.00% <ø> (ø)
src/locales/cs_CZ/location/city_pattern.ts 100.00% <ø> (ø)
src/locales/de/location/city_pattern.ts 100.00% <ø> (ø)
src/locales/de_AT/location/city_pattern.ts 100.00% <ø> (ø)
src/locales/de_CH/location/city_pattern.ts 100.00% <ø> (ø)
src/locales/dv/location/city_pattern.ts 100.00% <ø> (ø)
... and 140 more

... and 1 file with indirect coverage changes

Shinigami92
Shinigami92 previously approved these changes Apr 27, 2023
View reviewed changes
@ST-DDT ST-DDT marked this pull request as ready for review April 27, 2023 18:30
@ST-DDT ST-DDT requested a review from a team as a code owner April 27, 2023 18:30
@ST-DDT ST-DDT requested review from Shinigami92 and a team April 27, 2023 18:30
@ST-DDT ST-DDT requested review from a team April 27, 2023 20:09
@ST-DDT ST-DDT enabled auto-merge (squash) April 28, 2023 13:18
@ST-DDT ST-DDT merged commit 3cfeb38 into next Apr 28, 2023
15 checks passed
@ST-DDT ST-DDT deleted the docs/full-url-to-absolute branch April 28, 2023 13:40
@ST-DDT ST-DDT mentioned this pull request May 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: bug Something isn't working c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

Remove target=_blank from internal links in module overviews
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox