docs: Document what should appear in migration guide #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmayer
added
c: docs
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2138 +/- ##
=======================================
Coverage 99.59% 99.60%
=======================================
Files 2607 2607
Lines 244977 244977
Branches 1146 1153 +7
=======================================
+ Hits 243992 244006 +14
+ Misses 958 944 -14
Partials 27 27 |
ST-DDT
reviewed
May 9, 2023
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Shinigami92
reviewed
May 10, 2023
ST-DDT
previously approved these changes
May 10, 2023
|
i feel its useful to have it somewhere to refer people to if we ask them to document (or not document) changes in the guide. |
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
ST-DDT
previously approved these changes
May 12, 2023
Shinigami92
reviewed
May 12, 2023
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Shinigami92
previously approved these changes
May 12, 2023
ST-DDT
reviewed
May 12, 2023
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
ST-DDT
approved these changes
May 12, 2023
Shinigami92
approved these changes
May 12, 2023
import-brain
approved these changes
May 12, 2023
xDivisionByZerox
approved these changes
May 12, 2023
There was a problem hiding this comment.
TBH, I think this section is currently a little too verbose. Most one-time contributors will not implement anything that is noteworthy in the migrations guide. And if they do so the faker team can guide them in the review process.
On the other side, I'm happy that it is written somewhere, at least.
|
I think in general CONTRIBUTING is probably too verbose but probably easiest to add this and do a general cleanup/shortening later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2079