Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused dependencies #2298

Merged
merged 3 commits into from Aug 7, 2023
Merged

chore: remove unused dependencies #2298

merged 3 commits into from Aug 7, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Aug 6, 2023

Remove unused dependencies.
Not exactly sure about these ones nor that these are the only unused ones.

They might be used somewhere but pnm run preflight still runs without issues without them.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior c: dependencies Pull requests that adds/updates a dependency labels Aug 6, 2023
@ST-DDT ST-DDT requested review from a team August 6, 2023 14:38
@ST-DDT ST-DDT self-assigned this Aug 6, 2023
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #2298 (6438a3f) into next (3cecae9) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2298   +/-   ##
=======================================
  Coverage   99.59%   99.60%           
=======================================
  Files        2644     2644           
  Lines      245772   245772           
  Branches     1083     1085    +2     
=======================================
+ Hits       244779   244802   +23     
+ Misses        966      943   -23     
  Partials       27       27           

see 2 files with indirect coverage changes

@ST-DDT ST-DDT marked this pull request as ready for review August 6, 2023 14:44
@Shinigami92
Copy link
Member

Did you try run docs:dev and such things?

@ST-DDT
Copy link
Member Author

ST-DDT commented Aug 6, 2023

Did you try run docs:dev and such things?

preflight and docs:dev

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The react deps might be from vitepress v0? In the end, this shouldn't really matter anyway.

@ST-DDT ST-DDT merged commit 0a6e6ef into next Aug 7, 2023
19 checks passed
@ST-DDT ST-DDT deleted the dependencies/remove-unused branch August 7, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: dependencies Pull requests that adds/updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants