Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add da locale #2321

Closed
wants to merge 2 commits into from
Closed

feat(locale): add da locale #2321

wants to merge 2 commits into from

Conversation

stonor
Copy link
Contributor

@stonor stonor commented Aug 16, 2023

No description provided.

@stonor stonor requested a review from a team August 16, 2023 12:23
@stonor stonor requested a review from a team as a code owner August 16, 2023 12:23
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2321 (5416a93) into next (68f3ac4) will increase coverage by 0.00%.
Report is 1 commits behind head on next.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             next    #2321     +/-   ##
=========================================
  Coverage   99.59%   99.60%             
=========================================
  Files        2644     2737     +93     
  Lines      245617   249705   +4088     
  Branches     1080     1078      -2     
=========================================
+ Hits       244626   248712   +4086     
- Misses        964      966      +2     
  Partials       27       27             
Files Changed Coverage Δ
src/locale/da.ts 100.00% <100.00%> (ø)
src/locale/index.ts 100.00% <100.00%> (ø)
src/locales/da/animal/bear.ts 100.00% <100.00%> (ø)
src/locales/da/animal/bird.ts 100.00% <100.00%> (ø)
src/locales/da/animal/cat.ts 100.00% <100.00%> (ø)
src/locales/da/animal/cetacean.ts 100.00% <100.00%> (ø)
src/locales/da/animal/cow.ts 100.00% <100.00%> (ø)
src/locales/da/animal/crocodilia.ts 100.00% <100.00%> (ø)
src/locales/da/animal/dog.ts 100.00% <100.00%> (ø)
src/locales/da/animal/fish.ts 100.00% <100.00%> (ø)
... and 85 more

... and 1 file with indirect coverage changes

@import-brain import-brain added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Aug 16, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Aug 17, 2023

Thanks for your contribution.

Could you please split this PR into one per category (e.g. person, animal)?
(Small categories may be grouped, but please ~<20 files per PR)
We don't have any Danish people on our team and these huge PRs tend to take forever to review.

@stonor
Copy link
Contributor Author

stonor commented Aug 18, 2023

@ST-DDT OK, I'll add pull requests in drips instead. First one: #2324. Let's close this one.

@stonor stonor closed this Aug 18, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Aug 18, 2023

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants