Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention file limits for locale PRs #2322

Merged
merged 3 commits into from Sep 8, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Aug 17, 2023

When adding or changing locales, some PRs get huge and thus hard to review.
I would like to add a rule that requests PRs to stay limited in size.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Aug 17, 2023
@ST-DDT ST-DDT self-assigned this Aug 17, 2023
@ST-DDT ST-DDT requested a review from a team August 17, 2023 18:44
@ST-DDT ST-DDT requested a review from a team as a code owner August 17, 2023 18:44
@ST-DDT ST-DDT requested a review from a team August 17, 2023 18:48
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #2322 (ff52c0d) into next (630375b) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2322   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files        2770     2770           
  Lines      251751   251751           
  Branches     1085     1086    +1     
=======================================
+ Hits       250774   250776    +2     
+ Misses        950      948    -2     
  Partials       27       27           

see 2 files with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team September 6, 2023 08:58
@ST-DDT ST-DDT merged commit 8d7de9f into next Sep 8, 2023
19 checks passed
@ST-DDT ST-DDT deleted the docs/contributing/reviewer-sanity branch September 8, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants