Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(unicorn): no-hex-escape #2440

Merged
merged 4 commits into from Oct 9, 2023
Merged

infra(unicorn): no-hex-escape #2440

merged 4 commits into from Oct 9, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 7, 2023

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 7, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 7, 2023
@ST-DDT ST-DDT requested review from a team October 7, 2023 13:13
@ST-DDT ST-DDT self-assigned this Oct 7, 2023
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enforces a convention ]...[ for consistency and clarity.

Good think unicode encoding is so much more clear for me as a human than hex encoding xD

import-brain
import-brain previously approved these changes Oct 7, 2023
Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find either very readable. Could we define a constant for a non breaking space like

const nbsp = "\ua00"

@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 8, 2023

I don't find either very readable. Could we define a constant for a non breaking space like

const nbsp = "\ua00"

Done

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #2440 (ce4d46b) into next (1e01e53) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2440      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files        2823     2823              
  Lines      255523   255525       +2     
  Branches     1106     1106              
==========================================
- Hits       254487   254481       -6     
- Misses       1008     1016       +8     
  Partials       28       28              
Files Coverage Δ
src/modules/git/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team October 8, 2023 17:46
@ST-DDT ST-DDT enabled auto-merge (squash) October 9, 2023 15:26
@ST-DDT ST-DDT merged commit a1ec929 into next Oct 9, 2023
20 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/no-hex-escape branch October 9, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants