Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra(unicorn): no-zero-fractions #2453

Merged
merged 3 commits into from
Oct 22, 2023
Merged

infra(unicorn): no-zero-fractions #2453

merged 3 commits into from
Oct 22, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 9, 2023 •
edited
Loading

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 9, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 9, 2023
@ST-DDT ST-DDT requested review from a team October 9, 2023 10:48
@ST-DDT ST-DDT self-assigned this Oct 9, 2023
@ST-DDT ST-DDT mentioned this pull request Oct 9, 2023
Open
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #2453 (6a9638a) into next (f222448) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2453   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files        2823     2823           
  Lines      255520   255520           
  Branches     1105     1105           
=======================================
+ Hits       254474   254481    +7     
+ Misses       1018     1011    -7     
  Partials       28       28

see 2 files with indirect coverage changes

@matthewmayer
Copy link
Contributor

I don't personally like this rule even if 1.0 and 1 mean the same thing in JS 1.0 hints that you are dealing with floating point numbers.

@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Oct 9, 2023
ST-DDT
ST-DDT commented Oct 17, 2023
View reviewed changes
Copy link
Member Author

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Team Decision

No, we don't want this because the zero fractions point to decimal values, even if it doesn't have a runtime impact.

@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Oct 17, 2023
@ST-DDT ST-DDT force-pushed the infra/unicorn/no-zero-fractions branch from 1eea3fd to 3360a31 Compare October 17, 2023 21:29
@ST-DDT ST-DDT merged commit b55ac80 into next Oct 22, 2023
20 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/no-zero-fractions branch October 22, 2023 20:49
@dagistan-tuncbilek dagistan-tuncbilek mentioned this pull request Jun 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ST-DDT @matthewmayer @xDivisionByZerox