Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra(unicorn): prefer-ternary #2464

Merged
merged 11 commits into from Oct 26, 2023
Merged

infra(unicorn): prefer-ternary #2464

merged 11 commits into from Oct 26, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 10, 2023 •
edited

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 10, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 10, 2023
@ST-DDT ST-DDT requested review from a team October 10, 2023 10:05
@ST-DDT ST-DDT self-assigned this Oct 10, 2023
@ST-DDT ST-DDT mentioned this pull request Oct 10, 2023
Open
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 10, 2023

This is probably one of the more controversial rules.

@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited

Codecov Report

Merging #2464 (35518d2) into next (8a405fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2464   +/-   ##
=======================================
  Coverage   99.58%   99.59%           
=======================================
  Files        2823     2823           
  Lines      255520   255503   -17     
  Branches     1101     1105    +4     
=======================================
- Hits       254464   254463    -1     
+ Misses       1028     1012   -16     
  Partials       28       28
Files Coverage Δ
src/modules/date/index.ts 100.00% <100.00%> (ø)
src/modules/finance/index.ts 100.00% <100.00%> (ø)
src/modules/internet/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

matthewmayer
matthewmayer requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree. Long ternaries are ugly and hard to read.

@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Oct 10, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 15, 2023

@matthewmayer Are there any changes that improve readability for you or would you like to revert them all?

ST-DDT
ST-DDT commented Oct 17, 2023
View reviewed changes
Copy link
Member Author

@ST-DDT ST-DDT left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Team Decision

We will permanently disable the rule.

src/modules/finance/index.ts Show resolved Hide resolved
src/modules/finance/index.ts Outdated Show resolved Hide resolved
src/modules/internet/index.ts Show resolved Hide resolved
src/modules/date/index.ts Outdated Show resolved Hide resolved
src/modules/person/index.ts Outdated Show resolved Hide resolved
src/simple-faker.ts Outdated Show resolved Hide resolved
src/utils/merge-locales.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Oct 17, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 20, 2023

Ready for review.

@ST-DDT ST-DDT requested review from matthewmayer and a team October 20, 2023 09:01
@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) October 26, 2023 22:05
@xDivisionByZerox xDivisionByZerox merged commit 9297e5b into next Oct 26, 2023
20 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/prefer-ternary branch October 26, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@import-brain import-brain import-brain approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ST-DDT @matthewmayer @import-brain @xDivisionByZerox