Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra(typescript-eslint): strict-type-checked #2467

Merged
merged 13 commits into from Nov 4, 2023
Merged

infra(typescript-eslint): strict-type-checked #2467

merged 13 commits into from Nov 4, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 10, 2023 •
edited

Enables the @typescript-eslint/strict-type-checked lint rules.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 10, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 10, 2023
@ST-DDT ST-DDT self-assigned this Oct 10, 2023
@ST-DDT ST-DDT added the s: on hold Blocked by something or frozen to avoid conflicts label Oct 10, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 10, 2023

Blocked by #2463

@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited

Codecov Report

Merging #2467 (74aefea) into next (22003bb) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2467      +/-   ##
==========================================
- Coverage   99.58%   99.58%   -0.01%     
==========================================
  Files        2819     2819              
  Lines      255135   255134       -1     
  Branches     1101     1101              
==========================================
- Hits       254080   254074       -6     
- Misses       1027     1032       +5     
  Partials       28       28
Files Coverage Δ
src/modules/finance/index.ts 100.00% <100.00%> (ø)
src/modules/image/index.ts 100.00% <100.00%> (ø)
src/modules/word/filter-word-list-by-length.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 10, 2023

Blocked by #2468

@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label Oct 26, 2023
@ST-DDT ST-DDT requested review from a team October 26, 2023 21:51
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 26, 2023

Ready for review.

@ST-DDT ST-DDT marked this pull request as ready for review October 26, 2023 21:51
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team October 28, 2023 20:25
@ST-DDT ST-DDT enabled auto-merge (squash) November 4, 2023 09:34
@ST-DDT ST-DDT merged commit 358572d into next Nov 4, 2023
20 checks passed
@ST-DDT ST-DDT deleted the infra/typescript-eslint/strict-type-checked branch November 4, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ST-DDT @xDivisionByZerox