Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix deprecated text for internet.password #2486

Merged

Conversation

rcbyr
Copy link
Contributor

@rcbyr rcbyr commented Oct 20, 2023

The .password is missing in the "deprecated" message.

@rcbyr rcbyr requested a review from a team as a code owner October 20, 2023 19:24
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 20, 2023
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Oct 20, 2023
@ST-DDT ST-DDT requested review from a team October 20, 2023 19:31
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #2486 (84db7c3) into next (a882244) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2486   +/-   ##
=======================================
  Coverage   99.57%   99.58%           
=======================================
  Files        2823     2823           
  Lines      255517   255517           
  Branches     1095     1102    +7     
=======================================
+ Hits       254439   254457   +18     
+ Misses       1050     1032   -18     
  Partials       28       28           
Files Coverage Δ
src/modules/internet/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you :)

@ST-DDT ST-DDT merged commit 8540381 into faker-js:next Oct 21, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants