Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(unicorn): prefer-module #2510

Merged
merged 14 commits into from Nov 14, 2023
Merged

infra(unicorn): prefer-module #2510

merged 14 commits into from Nov 14, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 27, 2023

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 27, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 27, 2023
@ST-DDT ST-DDT requested review from a team October 27, 2023 21:21
@ST-DDT ST-DDT self-assigned this Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2510 (72ea9ef) into next (7e3c92e) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2510   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files        2806     2806           
  Lines      250064   250064           
  Branches     1099     1100    +1     
=======================================
+ Hits       249004   249009    +5     
+ Misses       1032     1027    -5     
  Partials       28       28           

see 1 file with indirect coverage changes

scripts/generate-locales.ts Show resolved Hide resolved
@ST-DDT ST-DDT enabled auto-merge (squash) November 6, 2023 08:34
@ST-DDT ST-DDT disabled auto-merge November 6, 2023 08:34
@ST-DDT ST-DDT enabled auto-merge (squash) November 13, 2023 08:13
@ST-DDT ST-DDT disabled auto-merge November 13, 2023 08:21
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team November 13, 2023 08:27
@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 14, 2023

Team Decision

This is largely unchanged since creation and has been approved for more than a week (if you ignore the minor merge conflicts).

@ST-DDT ST-DDT merged commit 932a875 into next Nov 14, 2023
20 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/prefer-module branch November 14, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants