Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale): incomplete airline names in zh_CN #2558

Merged
merged 1 commit into from Nov 25, 2023
Merged

fix(locale): incomplete airline names in zh_CN #2558

merged 1 commit into from Nov 25, 2023

Conversation

CoolPlayLin
Copy link
Contributor

@CoolPlayLin CoolPlayLin commented Nov 25, 2023 •
edited

Add incomplete airline names to make them consistent formatting

@CoolPlayLin CoolPlayLin requested a review from a team as a code owner November 25, 2023 10:09
@CoolPlayLin CoolPlayLin changed the title 🐛 fix: add missed string fix: add missed string 🐛 Nov 25, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Merging #2558 (3710c2a) into next (c2b9523) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2558      +/-   ##
==========================================
- Coverage   99.57%   99.56%   -0.01%     
==========================================
  Files        2805     2805              
  Lines      250126   250126              
  Branches     1105     1103       -2     
==========================================
- Hits       249065   249049      -16     
- Misses       1033     1049      +16     
  Partials       28       28
Files Coverage Δ
src/locales/zh_CN/airline/airline.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT changed the title fix: add missed string 🐛 fix(locale): incomplete airline names in zh_CN Nov 25, 2023
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: airline Something is referring to the airline module c: bug Something isn't working labels Nov 25, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 25, 2023
@CoolPlayLin CoolPlayLin removed their assignment Nov 25, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Nov 25, 2023

Google translate doesnt see a difference, but AFAICT the other airlines have the same suffix.

@ST-DDT ST-DDT requested review from a team November 25, 2023 10:23
@matthewmayer
Copy link
Contributor

It's just gongsi or "company" on the end which is standard.

@xDivisionByZerox xDivisionByZerox merged commit 5525b55 into faker-js:next Nov 25, 2023
31 of 32 checks passed
@CoolPlayLin CoolPlayLin deleted the add-missed-string branch November 26, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees
No one assigned
Labels
c: bug Something isn't working c: locale Permutes locale definitions m: airline Something is referring to the airline module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CoolPlayLin @ST-DDT @matthewmayer @xDivisionByZerox