Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helpers): fix examples on internal functions #2559

Merged
merged 3 commits into from Dec 1, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 25, 2023

Some very minor cleanup of jsdocs on internal functions.


Found during the review of: #2557

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent m: helpers Something is referring to the helpers module labels Nov 25, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 25, 2023
@ST-DDT ST-DDT requested review from a team November 25, 2023 11:28
@ST-DDT ST-DDT self-assigned this Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Merging #2559 (8f1eb52) into next (2eca5bc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2559   +/-   ##
=======================================
  Coverage   99.57%   99.58%           
=======================================
  Files        2805     2805           
  Lines      250166   250168    +2     
  Branches     1103     1108    +5     
=======================================
+ Hits       249101   249120   +19     
+ Misses       1037     1020   -17     
  Partials       28       28           
Files Coverage Δ
src/modules/helpers/index.ts 99.01% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you create this due to the comments in #2557? Good catch, tho 👍

@ST-DDT ST-DDT enabled auto-merge (squash) December 1, 2023 17:04
@ST-DDT ST-DDT merged commit 9dd57d7 into next Dec 1, 2023
38 checks passed
@ST-DDT ST-DDT deleted the jsdocs/helpers/legacyRegexpStringParse branch December 1, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: docs Improvements or additions to documentation m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants