refactor(number): deprecate precision in favor of multipleOf in float #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDivisionByZerox
added
p: 1-normal
ST-DDT
reviewed
Nov 30, 2023
matthewmayer
previously requested changes
Dec 1, 2023
…cate-precision-in-favor-of-multiple-of
ST-DDT
reviewed
Dec 11, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2564 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 2807 2807
Lines 250379 250401 +22
Branches 1143 1141 -2
=======================================
+ Hits 249313 249337 +24
+ Misses 1038 1036 -2
Partials 28 28
|
ST-DDT
previously approved these changes
Dec 19, 2023
|
@xDivisionByZerox There appears to be merge conflicts. |
…cate-precision-in-favor-of-multiple-of
ST-DDT
approved these changes
Dec 29, 2023
matthewmayer
approved these changes
Dec 29, 2023
ST-DDT
deleted the
refactor/number/deprecate-precision-in-favor-of-multiple-of
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecated the property
precisioninfaker.number.float. Additionally, adds the propertymultipleOf.Additional information
Fixes #1596.
Extracted from #1855.