Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(company)!: remove v8 deprecated company methods #2726

Merged
merged 4 commits into from
Mar 12, 2024
Merged

refactor(company)!: remove v8 deprecated company methods #2726

merged 4 commits into from
Mar 12, 2024

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: company Something is referring to the company module labels Mar 8, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Mar 8, 2024
@Shinigami92 Shinigami92 self-assigned this Mar 8, 2024
@Shinigami92 Shinigami92 force-pushed the remove-deprecated-company-methods branch from 4c43763 to dd5d255 Compare March 8, 2024 22:53
@Shinigami92 Shinigami92 marked this pull request as ready for review March 8, 2024 22:53
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 8, 2024 22:53
@codecov Codecov
Copy link

codecov bot commented Mar 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (e130549) to head (2404f3b).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #2726    +/-   ##
========================================
  Coverage   99.57%   99.57%            
========================================
  Files        3034     3034            
  Lines      250659   250522   -137     
  Branches      988      988            
========================================
- Hits       249583   249468   -115     
+ Misses       1047     1025    -22     
  Partials       29       29
Files Coverage Δ
src/definitions/company.ts 0.00% <ø> (ø)
src/modules/company/index.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Mar 9, 2024
View reviewed changes
@ST-DDT ST-DDT requested review from a team March 9, 2024 02:10
matthewmayer
matthewmayer requested changes Mar 9, 2024
View reviewed changes
docs/guide/upgrading_v9/2726.md Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team March 9, 2024 08:50
xDivisionByZerox
xDivisionByZerox requested changes Mar 9, 2024
View reviewed changes
docs/guide/upgrading_v9/2726.md Show resolved Hide resolved
src/definitions/company.ts Show resolved Hide resolved
@ST-DDT ST-DDT enabled auto-merge (squash) March 12, 2024 14:42
@ST-DDT ST-DDT merged commit 19bcf88 into next Mar 12, 2024
30 checks passed
@ST-DDT ST-DDT deleted the remove-deprecated-company-methods branch March 12, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: company Something is referring to the company module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shinigami92 @matthewmayer @ST-DDT @xDivisionByZerox