locale(en): remove word examples that contain spaces #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkuczynski
previously approved these changes
Jan 24, 2022
There was a problem hiding this comment.
We could extend conjunction list with https://7esl.com/conjunctions-list/ (skipping those which contain spaces)
done |
import-brain
previously approved these changes
Jan 25, 2022
Shinigami92
added
the
c: refactor
|
@griest024 Tests are running red, I assume you need to update the expected seeded values due to index changes |
Shinigami92
modified the milestones:
v6.3 - Next Minor,
v7.0 - Next Minor,
v7 - Current Major
xDivisionByZerox
approved these changes
Jun 17, 2022
xDivisionByZerox
added
m: word
ST-DDT
force-pushed
the
fix/locales/en/word/spaces
branch
from
51a03fd
to
efd281c
Compare
ST-DDT
removed
the
c: refactor
|
I updated this so we can either merge or discard it. |
Codecov Report
@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2155 2155
Lines 236901 236885 -16
Branches 991 991
=======================================
- Hits 236016 236004 -12
+ Misses 864 860 -4
Partials 21 21
|
Shinigami92
approved these changes
Aug 5, 2022
pkuczynski
approved these changes
Aug 5, 2022
import-brain
approved these changes
Aug 5, 2022
ST-DDT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"word" to me implies that the string does not contain spaces. This PR removes all word examples that contain spaces other than
boo hoowhich was changed toboohoorelated to #276