Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use new X icon instead of twitter icon in social links #2825

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Apr 15, 2024

old

image

new

image

@matthewmayer matthewmayer requested a review from a team as a code owner April 15, 2024 09:39
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit efbf1ad
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/661cf5d70f7e3f00080b6dfa
😎 Deploy Preview https://deploy-preview-2825.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewmayer matthewmayer self-assigned this Apr 15, 2024
@matthewmayer matthewmayer added the c: docs Improvements or additions to documentation label Apr 15, 2024
@ST-DDT ST-DDT requested review from a team April 15, 2024 09:42
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Apr 15, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (a9929e2) to head (efbf1ad).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2825   +/-   ##
=======================================
  Coverage   99.95%   99.96%           
=======================================
  Files        2966     2966           
  Lines      212579   212579           
  Branches      946      949    +3     
=======================================
+ Hits       212484   212495   +11     
+ Misses         95       84   -11     

see 1 file with indirect coverage changes

@ST-DDT ST-DDT merged commit 9ff7c98 into faker-js:next Apr 15, 2024
24 checks passed
matthewmayer added a commit to matthewmayer/faker that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants