Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add favicon #2853

Draft
wants to merge 3 commits into
base: next
Choose a base branch
from
+11 −1
Draft

docs: add favicon #2853

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba52684
docs: add favicon
ST-DDT Apr 28, 2024
b242957
Merge branch 'next' into docs/favicon
ST-DDT May 18, 2024
7508336
Merge branch 'next' into docs/favicon
ST-DDT May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/.vitepress/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const config: UserConfig<DefaultTheme.Config> = {
description,

head: [
['link', { rel: 'icon', href: '/logo.svg' }],
['link', { rel: 'icon', href: '/favicon.svg' }],
['meta', { name: 'theme-color', content: '#40af7c' }],
[
'meta',
Expand Down
10 changes: 10 additions & 0 deletions docs/public/favicon.svg
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file could be optimized by using a tool like SVGOMG. I get a file size reduction from around 40% when doing so. Additionally, the paths are usually don't require a precision of more than 3 digits. You can round all of them using the "precision" slider on the mentioned tool.

This step will be required when uploading to simple-icons as well.

Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.