Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link to the latest release of the current version #2856

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 28, 2024

Fixes #2850 (part2)

This change can be tested by:

export BRANCH=v9
pnpm run docs:dev
export BRANCH=next
pnpm run docs:dev
export BRANCH=other
pnpm run docs:dev

v9
grafik

next
grafik

other
grafik

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Apr 28, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Apr 28, 2024
@ST-DDT ST-DDT requested review from a team April 28, 2024 12:39
@ST-DDT ST-DDT self-assigned this Apr 28, 2024
Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit bb8878c
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66308a93fc083600088b70e7
😎 Deploy Preview https://deploy-preview-2856.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (b87acb8) to head (83228b3).

❗ Current head 83228b3 differs from pull request most recent head bb8878c. Consider uploading reports for the commit bb8878c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2856      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2975     2973       -2     
  Lines      214451   212501    -1950     
  Branches      952      601     -351     
==========================================
- Hits       214378   212415    -1963     
- Misses         73       86      +13     

see 5 files with indirect coverage changes

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice 🚀

@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Apr 29, 2024

As general feedback: If providing screenshots, adding a "before" and "after" image is generally a good idea. If you don't want to do this, at least explain what this image shows that is different from the current behavior. I had difficulties understanding what this PR changed even with the provided title, description, and pictures. In fact, the images made it more confusing for me when I started looking at it.

@ST-DDT
Copy link
Member Author

ST-DDT commented Apr 30, 2024

If providing screenshots, adding a "before" and "after" image is generally a good idea.

Thanks, I try to keep it in mind.

@ST-DDT ST-DDT enabled auto-merge (squash) April 30, 2024 06:07
@ST-DDT ST-DDT merged commit 13dc420 into next Apr 30, 2024
18 checks passed
@ST-DDT ST-DDT deleted the docs/version/links branch May 14, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add v9.fakerjs.dev
4 participants