Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): show sidebar on "API Reference" page #2865

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

xDivisionByZerox
Copy link
Member

@xDivisionByZerox xDivisionByZerox commented Apr 29, 2024

Description

This PR introduces the sidebar navigation to the "API Reference" page. The uniformed layout of all pages will befinfit users when navigating the website by reducing mental overload through layout changes.

Additional Info

Previously suggested in #2855 (review).

@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Apr 29, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Apr 29, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team April 29, 2024 10:16
@xDivisionByZerox xDivisionByZerox self-assigned this Apr 29, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner April 29, 2024 10:16
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit c9ccd8b
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/662f73688bc9c600084b26d7
😎 Deploy Preview https://deploy-preview-2865.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (f682750) to head (c9ccd8b).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2865   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2975     2975           
  Lines      214451   214451           
  Branches      953      951    -2     
=======================================
+ Hits       214375   214376    +1     
+ Misses         76       75    -1     

see 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team April 29, 2024 10:20
@xDivisionByZerox xDivisionByZerox merged commit b87acb8 into next Apr 29, 2024
28 checks passed
@xDivisionByZerox xDivisionByZerox deleted the docs/show-sidebar-on-api-ref-page branch April 29, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants