Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bicycle_types files being named incorrectly #477

Merged
merged 4 commits into from Feb 14, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 12, 2022

Fixes #471

I decided to rename the files to bicycle_types instead of changing the definition to bicycle, because for the other vehicles there is already the type module (which probably should be called vehicle_types or car_types instead).

This fixes a bug that was already present in 5.5.3, but blocks writing working tests for the vehicle module. See also #469.

@ST-DDT ST-DDT added the c: bug Something isn't working label Feb 12, 2022
@ST-DDT ST-DDT requested a review from a team February 12, 2022 00:42
@ST-DDT ST-DDT self-assigned this Feb 12, 2022
@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #477 (abb5814) into main (e6bffb7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1919     1919              
  Lines      176291   176291              
  Branches      904      902       -2     
==========================================
- Hits       175136   175134       -2     
- Misses       1099     1101       +2     
  Partials       56       56              
Impacted Files Coverage Δ
src/locales/en/vehicle/bicycle_type.ts 100.00% <ø> (ø)
src/locales/ur/vehicle/bicycle_type.ts 100.00% <ø> (ø)
src/locales/en/vehicle/index.ts 100.00% <100.00%> (ø)
src/locales/ur/vehicle/index.ts 100.00% <100.00%> (ø)
src/vendor/unique.ts 95.96% <0.00%> (-1.62%) ⬇️

@Shinigami92 Shinigami92 requested a review from a team February 12, 2022 10:17
@Shinigami92 Shinigami92 added the p: 2-high Fix main branch label Feb 12, 2022
@ST-DDT ST-DDT merged commit 7a2a522 into main Feb 14, 2022
@ST-DDT ST-DDT deleted the fix/locales/behicle/bicycle_types branch February 14, 2022 16:17
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 2-high Fix main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vehicle bicycle_type incorrect file names
3 participants