refactor: convert mersenne into a class

[xDivisionByZerox]

Created in relation to #280.

Converted MersenneTwister19937 function to a js class declaration.

Things I want to change but need approval:

• proper camelcase for all methods and variables/properties
• remove the file scoped variable dbg in line 54 since it is not used anywhere
• property jsdocs for public methods

[codecov]

Codecov Report

Merging #530 (2113fee) into main (03c3d11) will increase coverage by 0.00%.
The diff coverage is 95.70%.

❗ Current head 2113fee differs from pull request most recent head 84c14f0. Consider uploading reports for the commit 84c14f0 to get more accurate results

@@           Coverage Diff           @@
##             main     #530   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1919     1919           
  Lines      176315   176364   +49     
  Branches      904      903    -1     
=======================================
+ Hits       175158   175208   +50     
+ Misses       1101     1100    -1     
  Partials       56       56           

Impacted Files	Coverage Δ
src/vendor/mersenne.ts	95.90% <95.59%> (+1.02%)	⬆️
src/mersenne.ts	100.00% <100.00%> (ø)

[xDivisionByZerox]

@Shinigami92 can you confirm that dbg in line 54 is unused and can be removed?
It gets assigned in line 205 but doesn't do anything.
I have a second branch on my fork where I removed it and all test still work fine.

[xDivisionByZerox]

I guess I fked up the method scoping (?). I'm gonna investigate this.

[Shinigami92]

dbg

Yes, it could be that this is not used, BUT maybe it is something like a global weird thing that does any magic sideeffect 😬
If not, please purge it with fire 🔥

[Shinigami92]

Had a first quick look and LGTM, will approve later when I review deeper
Maybe you will also like to improve some stuff

[xDivisionByZerox]

Yes, it could be that this is not used, BUT maybe it is something like a global weird thing that does any magic sideeffect 😬
If not, please purge it with fire 🔥

That's why I was asking if you could checkout my branch where I removed it since on my machine it works fine after removing. Or is there a way to trigger the CI pipeline manually on a specific branch?

[Shinigami92]

Or is there a way to trigger the CI pipeline manually on a specific branch?

The CI pipeline will be triggered when you open a PR. Just do that and we can close the PR if not needed.

[xDivisionByZerox]

From the CI results in #531 I can confirm that removing the file scoped variable dbg does not influence the results of any tests.

Will remove it now add the removal to this PR.

[Shinigami92]

Not sure why the codecov/patch hits so hard here, but the rewrite looks good to me 🤷

[Shinigami92]

Uhm... 👀
Somehow github lost the author when I pressed the rebase button 😯

I don't want to steel credits for that.
@xDivisionByZerox Could you jump into your source and do following?:

1. Update your main branch in your fork git switch main && git pull upstream (maybe GitHub can help with that)
2. switch into this branch in your fork git switch refactor/mersenne-twister-to-class
3. git pull --rebase
4. git rebase -i main
5. git push -f

[xDivisionByZerox]

I'm currently at work. Will fix this afternoon.

[xDivisionByZerox]

I'm just getting Everything up-to-date

[ST-DDT]

@Shinigami92 Everything looks good to me:

(The gui doesn't show the right avatars though)

[xDivisionByZerox]

Cool. That worked.