Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update maintainers #559

Merged
merged 2 commits into from
Mar 2, 2022
Merged

docs: update maintainers #559

merged 2 commits into from
Mar 2, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 24, 2022

Special thanks to https://aequitas-software.de/

@ST-DDT ST-DDT added the c: docs Improvements or additions to documentation label Feb 24, 2022
@ST-DDT ST-DDT requested a review from a team February 24, 2022 23:01
@ST-DDT ST-DDT self-assigned this Feb 24, 2022
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #559 (c450460) into main (d2c1c93) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1920     1920           
  Lines      176414   176414           
  Branches      904      904           
=======================================
  Hits       175257   175257           
  Misses       1101     1101           
  Partials       56       56           

prisis
prisis previously approved these changes Feb 25, 2022
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look into line 7 of this file, there is a date.
So I'm not sure if we want to preserve this document as a history/changelog or if we should update the timestamp and maybe link to the git history or somewhat

@JessicaSachs What are your thoughts about this?

import-brain
import-brain previously approved these changes Feb 26, 2022
@JessicaSachs
Copy link
Contributor

I don't think having a timestamp on this would be helpful. At some point we should probably remove the notice entirely or put it at the bottom of the website, etc and have a more prominent Teams page with nice photos and an emeritus section.

Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine with me to add your name here because you were there during this entire statement period. For future members I don't think that placing their names here would make a lot of sense and we should get a teams page.

@ST-DDT ST-DDT merged commit 357986b into main Mar 2, 2022
@ST-DDT ST-DDT deleted the docs/update-maintainers branch March 2, 2022 08:37
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants