-
-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ru-locale): renovate states/streets and domain suffix names #634
Conversation
Could you please add the sources for these list for easier verification? |
Codecov Report
@@ Coverage Diff @@
## main #634 +/- ##
========================================
Coverage 99.65% 99.65%
========================================
Files 1988 1988
Lines 210279 211108 +829
Branches 909 909
========================================
+ Hits 209555 210384 +829
Misses 705 705
Partials 19 19
|
We need somebody to check these. |
Provided several links to government sources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On first look with help of google translator, this PR looks valid to me.
But I would like if someone with russian knowledge could have a specific look over these enhancements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format wise this looks good. Haven't checked the translations yet.
A personal russian friend approved that everything is fine 👌 We will merge this as part of v6.2 |
testing some permissions temporariliy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format wise this looks good.
@pkuczynski You may need to approve or comment if you want further changes |
0157876
I merged the changes from main (street_title -> street_name). |
Updated:
Names of Russian regions according to official government sources
For instance:
Камчатская область
->Камчатский край
Кемеровская область
->Кемеровская область - Кузбасс
Республика Адыгея
->Республика Адыгея (Адыгея)
Республика Карачаево-Черкессия
->Карачаево-Черкесская Республика
Таймырский (Долгано-Ненецкий) автономный округ
->Красноярский край
- was merged with other stateStreet name
Added more street names
Street title
Added more street titles
Street suffix
Added new full and abbreviated names of suffixes
Domain suffix names according to the statistics of popular domain names registered by Russian domain providers
All names had been listed alphabetically.