Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ru-locale): renovate states/streets and domain suffix names #634

Merged
merged 15 commits into from
May 22, 2022
Merged

chore(ru-locale): renovate states/streets and domain suffix names #634

merged 15 commits into from
May 22, 2022

Conversation

serembon
Copy link
Contributor

@serembon serembon commented Mar 18, 2022

Updated:

  1. Names of Russian regions according to official government sources

    For instance:

  1. Street name

    Added more street names

  2. Street title

    Added more street titles

  3. Street suffix

    Added new full and abbreviated names of suffixes

  4. Domain suffix names according to the statistics of popular domain names registered by Russian domain providers

All names had been listed alphabetically.

@serembon serembon requested a review from a team as a code owner March 18, 2022 13:09
@serembon serembon changed the title chore: renovate Russian states names chore: renovate RU locale states names Mar 18, 2022
@ST-DDT ST-DDT added this to the v6.2 - New small features milestone Mar 18, 2022
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision labels Mar 18, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Mar 18, 2022

Could you please add the sources for these list for easier verification?

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #634 (8251ee5) into main (a0d25bb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main     #634    +/-   ##
========================================
  Coverage   99.65%   99.65%            
========================================
  Files        1988     1988            
  Lines      210279   211108   +829     
  Branches      909      909            
========================================
+ Hits       209555   210384   +829     
  Misses        705      705            
  Partials       19       19            
Impacted Files Coverage Δ
src/locales/ru/address/city_name.ts 100.00% <100.00%> (ø)
src/locales/ru/address/state.ts 100.00% <100.00%> (ø)
src/locales/ru/address/street_name.ts 100.00% <100.00%> (ø)
src/locales/ru/address/street_suffix.ts 100.00% <100.00%> (ø)
src/locales/ru/internet/domain_suffix.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT added the help wanted Extra attention is needed label Mar 18, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Mar 18, 2022

We need somebody to check these.

@serembon
Copy link
Contributor Author

Provided several links to government sources

@Shinigami92 Shinigami92 added the c: locale Permutes locale definitions label Mar 18, 2022
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On first look with help of google translator, this PR looks valid to me.
But I would like if someone with russian knowledge could have a specific look over these enhancements.

src/locales/ru/address/state.ts Outdated Show resolved Hide resolved
src/locales/ru/internet/domain_suffix.ts Show resolved Hide resolved
@Shinigami92 Shinigami92 added s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Mar 18, 2022
@import-brain import-brain added the c: chore PR that doesn't affect the runtime behavior label Mar 18, 2022
@serembon serembon changed the title chore: renovate RU locale states names chore: renovate RU locale states and domain suffix names Mar 18, 2022
@ST-DDT ST-DDT removed the c: chore PR that doesn't affect the runtime behavior label Mar 18, 2022
Shinigami92
Shinigami92 previously approved these changes Mar 18, 2022
@Shinigami92 Shinigami92 requested a review from a team March 18, 2022 21:25
ST-DDT
ST-DDT previously approved these changes Mar 18, 2022
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format wise this looks good. Haven't checked the translations yet.

@ST-DDT ST-DDT requested a review from a team March 18, 2022 22:45
@Shinigami92
Copy link
Member

Shinigami92 commented Mar 19, 2022

A personal russian friend approved that everything is fine 👌

We will merge this as part of v6.2

@ST-DDT ST-DDT removed the help wanted Extra attention is needed label Mar 19, 2022
@serembon serembon changed the title chore: renovate RU locale states and domain suffix names chore(ru-locale): renovate states and domain suffix names Mar 20, 2022
@Shinigami92 Shinigami92 dismissed ST-DDT’s stale review March 24, 2022 16:58

testing some permissions temporariliy

ST-DDT
ST-DDT previously approved these changes May 11, 2022
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format wise this looks good.

@ST-DDT ST-DDT requested review from a team May 11, 2022 20:49
Shinigami92
Shinigami92 previously approved these changes May 12, 2022
@Shinigami92
Copy link
Member

@pkuczynski You may need to approve or comment if you want further changes

pkuczynski
pkuczynski previously approved these changes May 18, 2022
@ST-DDT ST-DDT dismissed stale reviews from pkuczynski, Shinigami92, and themself via 0157876 May 21, 2022 17:29
@ST-DDT
Copy link
Member

ST-DDT commented May 21, 2022

I merged the changes from main (street_title -> street_name).

@ST-DDT ST-DDT requested review from a team May 21, 2022 17:31
@Shinigami92 Shinigami92 enabled auto-merge (squash) May 22, 2022 11:02
@Shinigami92 Shinigami92 merged commit b87dec8 into faker-js:main May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants