Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add ts import example in readme #719

Merged
merged 2 commits into from Mar 30, 2022
Merged

docs: add ts import example in readme #719

merged 2 commits into from Mar 30, 2022

Conversation

pkuczynski
Copy link
Member

I felt that this example is missing somehow if we have examples for other envs...

@pkuczynski pkuczynski self-assigned this Mar 28, 2022
@pkuczynski pkuczynski requested a review from a team as a code owner March 28, 2022 21:30
@pkuczynski pkuczynski added the c: docs Improvements or additions to documentation label Mar 28, 2022
@pkuczynski pkuczynski added this to the v6.1 - First bugfixes milestone Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022 •
edited

Codecov Report

Merging #719 (930a4ca) into main (7afd8c5) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 930a4ca differs from pull request most recent head 4198723. Consider uploading reports for the commit 4198723 to get more accurate results

@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1924     1924              
  Lines      177022   176983      -39     
  Branches      904      904              
==========================================
- Hits       175861   175822      -39     
  Misses       1105     1105              
  Partials       56       56
Impacted Files Coverage Δ
src/system.ts 96.44% <0.00%> (-0.02%) ⬇️
src/fake.ts 100.00% <0.00%> (ø)
src/word.ts 100.00% <0.00%> (ø)

ST-DDT
ST-DDT reviewed Mar 28, 2022
View reviewed changes
README.md Show resolved Hide resolved
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 28, 2022
@ST-DDT ST-DDT requested review from a team March 28, 2022 22:42
Shinigami92
Shinigami92 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have strong feelings about this suggestion
IMO it doesn't add currently no new value to the README, but if it helps others 🤷

@ST-DDT ST-DDT enabled auto-merge (squash) March 30, 2022 23:48
@ST-DDT ST-DDT merged commit f285dc9 into faker-js:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT left review comments

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@pkuczynski pkuczynski

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pkuczynski @ST-DDT @Shinigami92 @import-brain