Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use valid UUID for example in README #740

Merged
merged 2 commits into from Mar 31, 2022
Merged

Conversation

knpwrs
Copy link
Contributor

@knpwrs knpwrs commented Mar 31, 2022

The example UUID in the README confused me, then I read the docs and code and found that the fake UUIDs are indeed v4s.

@knpwrs knpwrs requested a review from a team as a code owner March 31, 2022 14:54
@knpwrs knpwrs changed the title Use valid UUID for example in README docs: Use valid UUID for example in README Mar 31, 2022
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 31, 2022
@ST-DDT ST-DDT requested review from a team March 31, 2022 15:21
README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #740 (f579a07) into main (7c6d9f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #740   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1924     1924           
  Lines      177022   177022           
  Branches      904      904           
=======================================
  Hits       175861   175861           
  Misses       1105     1105           
  Partials       56       56           

@ST-DDT ST-DDT merged commit 2e22845 into faker-js:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants