chore: removed outcommented dead code in commerce.ts #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimakan
changed the title
xDivisionByZerox
added
p: 1-normal
xDivisionByZerox
approved these changes
Apr 1, 2022
|
Please update the title to be semantically correct. Lines 3 to 17 in c3be3b1 |
rimakan
changed the title
|
done! do you mind taking a look, please? is it fine? |
ST-DDT
approved these changes
Apr 1, 2022
You already got my approval. What do you want more?^^ |
Codecov Report
@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 99.34% 99.34% -0.01%
==========================================
Files 1925 1925
Lines 177024 176996 -28
Branches 909 909
==========================================
- Hits 175871 175843 -28
Misses 1097 1097
Partials 56 56
|
well nothing now :D I just wanted you to check whether my pr's title was semantic or not :) |
Shinigami92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some 'dead' code according to #690