Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix mustache type warning and add some tests #753

Merged
merged 5 commits into from Apr 4, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 1, 2022

Ref: #541

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Apr 1, 2022
@ST-DDT ST-DDT added this to the v6.1 - First bugfixes milestone Apr 1, 2022
@ST-DDT ST-DDT requested review from a team April 1, 2022 22:33
@ST-DDT ST-DDT self-assigned this Apr 1, 2022
src/helpers.ts Show resolved Hide resolved
test/helpers.spec.ts Outdated Show resolved Hide resolved
src/helpers.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #753 (0652fd5) into main (9e03bcf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0652fd5 differs from pull request most recent head ff485c3. Consider uploading reports for the commit ff485c3 to get more accurate results

@@           Coverage Diff           @@
##             main     #753   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1918     1922    +4     
  Lines      176482   176476    -6     
  Branches      910      912    +2     
=======================================
  Hits       175324   175324           
+ Misses       1102     1096    -6     
  Partials       56       56           
Impacted Files Coverage Δ
src/helpers.ts 99.28% <100.00%> (+0.13%) ⬆️
src/random.ts 99.46% <0.00%> (-0.01%) ⬇️
src/datatype.ts 100.00% <0.00%> (ø)
src/definitions/address.ts 100.00% <0.00%> (ø)
src/locales/ar/address/index.ts 100.00% <0.00%> (ø)
src/locales/en/address/index.ts 100.00% <0.00%> (ø)
src/locales/he/address/index.ts 100.00% <0.00%> (ø)
src/locales/ur/address/index.ts 100.00% <0.00%> (ø)
src/locales/ar/address/postcode_by_state.ts 100.00% <0.00%> (ø)
src/locales/en/address/postcode_by_state.ts 100.00% <0.00%> (ø)
... and 5 more

@ST-DDT ST-DDT requested a review from Shinigami92 April 2, 2022 13:51
@ST-DDT ST-DDT mentioned this pull request Apr 2, 2022
@Shinigami92 Shinigami92 requested a review from a team April 3, 2022 12:27
@prisis prisis enabled auto-merge (squash) April 4, 2022 14:43
@prisis prisis disabled auto-merge April 4, 2022 14:46
@prisis prisis enabled auto-merge (squash) April 4, 2022 14:46
@prisis prisis merged commit 8b545b4 into main Apr 4, 2022
@Shinigami92 Shinigami92 deleted the feature/mustache-types-and-tests branch April 4, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants