Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: random word fails on undefined #771

Merged
merged 3 commits into from Apr 4, 2022
Merged

fix: random word fails on undefined #771

merged 3 commits into from Apr 4, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 4, 2022 •
edited

Fixes #770

@ST-DDT ST-DDT self-assigned this Apr 4, 2022
@ST-DDT ST-DDT added c: bug Something isn't working p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug labels Apr 4, 2022
@ST-DDT ST-DDT added this to the v6.1 - First bugfixes milestone Apr 4, 2022
@ST-DDT ST-DDT marked this pull request as ready for review April 4, 2022 08:27
@ST-DDT ST-DDT requested a review from a team as a code owner April 4, 2022 08:27
@ST-DDT ST-DDT requested a review from a team April 4, 2022 08:27
@ST-DDT ST-DDT mentioned this pull request Apr 4, 2022
Closed
@codecov
Copy link

codecov bot commented Apr 4, 2022 •
edited

Codecov Report

Merging #771 (4c12518) into main (8b545b4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4c12518 differs from pull request most recent head 16e1372. Consider uploading reports for the commit 16e1372 to get more accurate results

@@            Coverage Diff             @@
##             main     #771      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1918     1918              
  Lines      176479   176482       +3     
  Branches      914      910       -4     
==========================================
+ Hits       175322   175324       +2     
- Misses       1101     1102       +1     
  Partials       56       56
Impacted Files Coverage Δ
src/random.ts 99.46% <100.00%> (ø)
src/helpers.ts 99.14% <0.00%> (-0.14%) ⬇️

Shinigami92
Shinigami92 approved these changes Apr 4, 2022
View reviewed changes
src/random.ts Show resolved Hide resolved
@ST-DDT ST-DDT requested a review from a team April 4, 2022 08:54
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 4, 2022 14:57
@Shinigami92 Shinigami92 merged commit fb1b87e into main Apr 4, 2022
@ST-DDT ST-DDT deleted the fix/770/random/word-undefined branch April 5, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HonzaMac HonzaMac HonzaMac left review comments

@ra100 ra100 ra100 left review comments

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: bug Something isn't working p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.

TypeError: includes of undefined on Faker.system.commonFileName()
5 participants
@ST-DDT @HonzaMac @ra100 @Shinigami92 @import-brain