Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use vitepress v1 #993

Merged
merged 14 commits into from Aug 6, 2022
Merged

docs: use vitepress v1 #993

merged 14 commits into from Aug 6, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels May 24, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone May 24, 2022
@Shinigami92 Shinigami92 self-assigned this May 24, 2022
@codecov
Copy link

codecov bot commented May 24, 2022 •
edited

Codecov Report

Merging #993 (e85c944) into main (0668cfe) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
+ Coverage   99.62%   99.63%   +0.01%     
==========================================
  Files        2155     2155              
  Lines      236884   236884              
  Branches      990      994       +4     
==========================================
+ Hits       235996   236020      +24     
+ Misses        867      843      -24     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/finance/index.ts 99.76% <0.00%> (-0.24%) ⬇️
src/modules/internet/user-agent.ts 88.35% <0.00%> (+6.61%) ⬆️

Shinigami92
Shinigami92 commented May 24, 2022
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
docs/.vitepress/config.ts Show resolved Hide resolved
docs/.vitepress/config.ts Show resolved Hide resolved
@Shinigami92 Shinigami92 linked an issue May 24, 2022 that may be closed by this pull request
Dark Mode for fakerjs.dev website #197
Closed
@Shinigami92
Copy link
Member Author

Shinigami92 commented Jun 1, 2022 •
edited

@ST-DDT

faker/scripts/apidoc/signature.ts

Line 36 in 350bd35

const markdown = createMarkdownRenderer(

is now async 🤔
It returns Promise<MarkdownRenderer> instead of MarkdownRenderer

Edit: I have a local working stash but the html sanitizer throws errors due to the output is different.
Let's check that together when you have time.

@import-brain import-brain added the needs rebase There is a merge conflict label Jun 4, 2022
@Shinigami92 Shinigami92 mentioned this pull request Jun 5, 2022
Merged
@Shinigami92 Shinigami92 force-pushed the vitepress-v1 branch 2 times, most recently from 8f8ced6 to 0d44b78 Compare June 19, 2022 09:18
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Jun 19, 2022
@Shinigami92
Copy link
Member Author

Waiting on vuejs/vitepress#816

@Shinigami92 Shinigami92 requested a review from ST-DDT August 3, 2022 15:05
@Shinigami92 Shinigami92 marked this pull request as ready for review August 3, 2022 15:05
@Shinigami92 Shinigami92 requested a review from a team August 3, 2022 15:05
@Shinigami92 Shinigami92 requested a review from a team as a code owner August 3, 2022 15:05
@ST-DDT ST-DDT added needs rebase There is a merge conflict s: accepted Accepted feature / Confirmed bug labels Aug 4, 2022
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Aug 5, 2022
@Shinigami92 Shinigami92 requested review from ST-DDT and a team August 5, 2022 09:32
ST-DDT
ST-DDT approved these changes Aug 5, 2022
View reviewed changes
scripts/apidoc/signature.ts Show resolved Hide resolved
This was referenced Aug 5, 2022
Merged
Merged
@Shinigami92 Shinigami92 enabled auto-merge (squash) August 6, 2022 20:48
@Shinigami92 Shinigami92 merged commit 51a8863 into main Aug 6, 2022
@Shinigami92 Shinigami92 deleted the vitepress-v1 branch August 6, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiaking kiaking kiaking left review comments

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

Dark Mode for fakerjs.dev website
4 participants
@Shinigami92 @ST-DDT @kiaking @import-brain