Merge branch 'main' into fix-flaky-username-test

faker-ruby · May 9, 2024 · 0df1182 · 0df1182
2 parents dcedacb + 6595da9
commit 0df1182
Show file tree

Hide file tree

Showing 5 changed files with 42 additions and 10 deletions.
diff --git a/.github/workflows/push_gem.yml b/.github/workflows/push_gem.yml
@@ -0,0 +1,33 @@
+name: Push Gem
+
+on:
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  push:
+    if: github.repository == 'faker-ruby/faker'
+    runs-on: ubuntu-latest
+
+    permissions:
+      contents: write
+      id-token: write
+
+    steps:
+      # Set up
+      - name: Harden Runner
+        uses: step-security/harden-runner@a4aa98b93cab29d9b1101a6143fb8bce00e2eac4 # v2.7.1
+        with:
+          egress-policy: audit
+
+      - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@cacc9f1c0b3f4eb8a16a6bb0ed10897b43b9de49 # v1.176.0
+        with:
+          bundler-cache: true
+          ruby-version: ruby
+
+      # Release
+      - uses: rubygems/release-gem@612653d273a73bdae1df8453e090060bb4db5f31 # v1
diff --git a/Gemfile b/Gemfile
@@ -15,5 +15,4 @@ gem 'rubocop-rake', '0.6.0'
 gem 'simplecov', '0.22.0'
 gem 'test-unit', '3.6.2'
 gem 'timecop', '0.9.8'
-gem 'tzinfo', '2.0.6'
 gem 'yard', '0.9.36'
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -12,7 +12,7 @@ GEM
     coderay (1.1.3)
     concurrent-ruby (1.2.3)
     docile (1.4.0)
-    i18n (1.14.4)
+    i18n (1.14.5)
       concurrent-ruby (~> 1.0)
     json (2.7.2)
     language_server-protocol (3.17.0.3)

diff --git a/README.md b/README.md
@@ -24,6 +24,14 @@ and it was the original impetus for the creation of this gem.
 [rubydocs]: https://www.rubydoc.info/gems/faker/
 [changelog]: CHANGELOG.md
 
+## In the media
+
+- 📰 [With Great Humor Comes Great Developer Engagement] - KTH Royal Institute of Technology research
+- 🎧 [Computer und Kommunikation 4.5.2024, komplette Sendung] - Deutschland Funk Radio Interview
+
+[With Great Humor Comes Great Developer Engagement]: https://arxiv.org/pdf/2312.01680
+[Computer und Kommunikation 4.5.2024, komplette Sendung]: https://www.deutschlandfunk.de/computer-und-kommunikation-4-5-2024-komplette-sendung-dlf-16492b03-100.html
+
 ## Table of Contents
 
 - [Faker](#faker)

diff --git a/test/test_en_locale.rb b/test/test_en_locale.rb
@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-require 'tzinfo'
 require_relative 'test_helper'
 
 class TestEnLocale < Test::Unit::TestCase
@@ -40,13 +39,6 @@ def test_values_trimmed
     check_hash(en_file)
   end
 
-  def test_en_timezones_are_valid_iana_identifiers
-    faker_time_zones = Faker::Address.translate('faker.address.time_zone')
-    iana_time_zones = TZInfo::Timezone.all_identifiers
-
-    assert_empty(faker_time_zones.difference(iana_time_zones), "Found a time zone that isn't a valid IANA time zone identifier")
-  end
-
   def check_hash(hash)
     hash.each { |key, value| check_value(value) unless key == 'separator' }
   end